-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56945/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Greg Mann, and Joseph Wu.
Repository: mesos
Description
-------
This removes inconsistent use of the 'override' keyword where the
'LibeventSSLSocketImpl' class contained both a method explicitly
marked 'override' and implicitly 'override' functions. This is
diagnosed as an inconsistency by clang-4.0, e.g.,
/PATH/libevent_ssl_socket.hpp|43 col 27| warning: \
'connect' overrides a member function but is not marked \
'override' [-Winconsistent-missing-override]
virtual Future<Nothing> connect(const Address& address);
^
/PATH/socket.hpp|148 col 27| note: \
overridden virtual function is here
virtual Future<Nothing> connect(const Address& address) = 0;
A proper fix will be implemented as part of MESOS-4871.
Diffs
-----
3rdparty/libprocess/src/libevent_ssl_socket.hpp
e589a04d14378f265a8fca871c9f5b0c577f5713
Diff: https://reviews.apache.org/r/56945/diff/
Testing
-------
make check (OS X, clang/trunk).
Thanks,
Benjamin Bannier
