----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56813/#review166638 -----------------------------------------------------------
The description talks about the agent instead of master. Copy paste error? src/master/http.cpp (line 662) <https://reviews.apache.org/r/56813/#comment238642> same question as previous review. here and below. src/master/http.cpp (line 839) <https://reviews.apache.org/r/56813/#comment238646> is it possible that this is none? src/master/master.cpp (line 3446) <https://reviews.apache.org/r/56813/#comment238648> This sounds like we should call it AuthenticatedEntity or authentication::Entity instead :) Also, I'm wondering if we can actually call this struct `Principal` based on the standard/wikipedia definition of principal https://en.wikipedia.org/wiki/Principal_(computer_security)? ``` struct Principal { Option<string> name; map<string, string> claims; } ``` - Vinod Kone On Feb. 22, 2017, 7:53 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56813/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2017, 7:53 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7003 > https://issues.apache.org/jira/browse/MESOS-7003 > > > Repository: mesos > > > Description > ------- > > This patch updates the HTTP endpoint handlers in the > agent process to accept an `AuthenticationContext` > instead of an `Option<string>& principal`. > > > Diffs > ----- > > src/master/http.cpp e2fd71c5ae4178564b9a08756df5175aec5d6ca1 > src/master/master.hpp 764adb18ddf09b62529c5c96f8e4dfaf7803483e > src/master/master.cpp 2ef836536784d5fda23c80dc2304239b176a8942 > src/master/quota_handler.cpp 3ad28e4a9363a877d0610b529a6c17fb30ece37a > src/master/registrar.cpp d7134eea34102ab7b24d2f0131363bdd9005cfd3 > src/master/weights_handler.cpp 4f6a4cd29d27b64cbc9ee6d8909f79812313b681 > > Diff: https://reviews.apache.org/r/56813/diff/ > > > Testing > ------- > > Testing details can be found at the end of this review chain. > > > Thanks, > > Greg Mann > >
