> On Feb. 24, 2017, 1:53 a.m., Vinod Kone wrote: > > src/master/validation.cpp, line 339 > > <https://reviews.apache.org/r/56901/diff/2/?file=1642754#file1642754line339> > > > > Should this be a CHECK? When is this possible?
We'll soon be adding an authentication module (the JWT authenticator) which will return authentication contexts without a principal, so it's possible. While our default implementations will not produce credentials intended for schedulers, I think we should write the validation code to accommodate the generic case, and an arbitrary custom authenticator might decide to make wider use of authContexts which do not contain principals. > On Feb. 24, 2017, 1:53 a.m., Vinod Kone wrote: > > src/master/validation.cpp, line 1644 > > <https://reviews.apache.org/r/56901/diff/2/?file=1642754#file1642754line1644> > > > > can authContext be `Some` but not contain `principal`? See above. > On Feb. 24, 2017, 1:53 a.m., Vinod Kone wrote: > > src/master/validation.cpp, line 1796 > > <https://reviews.apache.org/r/56901/diff/2/?file=1642754#file1642754line1796> > > > > ditto. See above. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56901/#review166633 ----------------------------------------------------------- On Feb. 22, 2017, 7:48 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56901/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2017, 7:48 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7003 > https://issues.apache.org/jira/browse/MESOS-7003 > > > Repository: mesos > > > Description > ------- > > This patch updates master validation code to make use > of the `AuthenticationContext` instead of an > `Option<string> principal`. > > > Diffs > ----- > > src/master/validation.hpp f03b3280704083be1ca074ca07c69edbb49dae19 > src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f > > Diff: https://reviews.apache.org/r/56901/diff/ > > > Testing > ------- > > Testing details can be found at the end of this review chain. > > > Thanks, > > Greg Mann > >
