----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57030/#review166764 -----------------------------------------------------------
Fix it, then Ship it! src/tests/master_validation_tests.cpp (lines 1835 - 1836) <https://reviews.apache.org/r/57030/#comment238840> We should test the case where the task has unallocated resources as well, per my suggestion on the previous review. - Benjamin Mahler On Feb. 24, 2017, 10:52 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57030/ > ----------------------------------------------------------- > > (Updated Feb. 24, 2017, 10:52 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-6636 > https://issues.apache.org/jira/browse/MESOS-6636 > > > Repository: mesos > > > Description > ------- > > With support for multi-role frameworks, we need to make sure that > individual task cannot mix allocation roles. > > > Diffs > ----- > > src/master/validation.cpp b8c6b49ca5ca1f15e58a2967adc335436a35071f > src/tests/master_validation_tests.cpp > 45254739e2a62fed7008ceada7a8f64bb9ee4e31 > > Diff: https://reviews.apache.org/r/57030/diff/ > > > Testing > ------- > > > Thanks, > > Jay Guo > >
