----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56624/#review167072 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/libprocess/src/tests/http_tests.cpp (line 1776) <https://reviews.apache.org/r/56624/#comment239199> `/Option<Principal>::none()/None()/` Not so sure if it works in macros, but I did test changing it in the previous commit and compiling it. - Alexander Rojas On Feb. 28, 2017, 7:59 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56624/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2017, 7:59 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7003 > https://issues.apache.org/jira/browse/MESOS-7003 > > > Repository: mesos > > > Description > ------- > > This patch updates the HTTP-related libprocess > tests to use authenticated handlers which accept > the `Principal` type instead of an > `Option<string> principal`. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/http_tests.cpp > fb4da9aecff0370d97a15269c5d8fffb30e0478f > > Diff: https://reviews.apache.org/r/56624/diff/ > > > Testing > ------- > > Testing information can be found at the end of this review chain. > > > Thanks, > > Greg Mann > >
