----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56806/#review167128 -----------------------------------------------------------
Fix it, then Ship it! src/tests/containerizer/docker_containerizer_tests.cpp (line 2982) <https://reviews.apache.org/r/56806/#comment239273> Looks like this one only has 1 use as well. It seems like rest of the places you just replaced the 1 use with `offer.slave_id()`. - Michael Park On Feb. 28, 2017, 11:13 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56806/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2017, 11:13 a.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > Fixed some clang-tidy warnings. > > > Diffs > ----- > > src/common/protobuf_utils.cpp 944263bbaa87a65005fd924bccfadb7293312fa0 > src/master/detector/detector.cpp 1ebe5af4219a7e1ec1cbf22b440dd3ecaad4b4a9 > src/slave/slave.cpp fc480ae23ffa5cdeeb79b3621a08e1f8703bc01a > src/tests/containerizer/docker_containerizer_tests.cpp > e760f47b3d8c4054bad8ff65269107d5583c9a90 > src/tests/fetcher_cache_tests.cpp e5eee9bce56edacb74ad80ff859ddbc5048c73d0 > src/tests/hook_tests.cpp 237df8102941cd143c4d61016963e62a69c43382 > src/tests/persistent_volume_endpoints_tests.cpp > 1cc6c9d01a3a473f5a44210ea725310ea5931ff6 > > Diff: https://reviews.apache.org/r/56806/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
