----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55657/#review167135 -----------------------------------------------------------
CMakeLists.txt (lines 73 - 81) <https://reviews.apache.org/r/55657/#comment239285> The full list should ignore some of the bootstrap artifacts, docs, support files, and autotools files, as well as the build directory: ``` # List of sources we will ignore when generating a source package. # We assume there are no artifacts from an autotools build. # # NOTE: An in-source build is not supported. The build directory # must be different than the source directory. set(CPACK_SOURCE_IGNORE_FILES .clang-format; .gitignore; .reviewboardrc; bootstrap.bat; bootstrap; configure.ac; Doxyfile; mesos.pc.in; /.git/; /docs/; /m4/; /mpi/; /site/; /support/; ${CMAKE_BINARY_DIR}; ) # Convert the ignore list to a string (as required by CPack). set(CPACK_SOURCE_IGNORE_FILES "${CPACK_SOURCE_IGNORE_FILES}") ``` CMakeLists.txt (line 83) <https://reviews.apache.org/r/55657/#comment239286> Remove this line, as the vendor should define this when invoking CMake. CMakeLists.txt (line 84) <https://reviews.apache.org/r/55657/#comment239321> To affect the binary packages, `CPACK_PACKAGE_FILE_NAME` should be set too. CMakeLists.txt (line 87) <https://reviews.apache.org/r/55657/#comment239322> Instead of specifying the package format, we can leave the format of the package up to the end-user. For binary packages, they can define: CPACK_BINARY_(BUNDLE|DEB|DRAGNDROP|IFW|NSIS|OSXX11|PACKAGEMAKER|RPM|STGZ|TBZ2|TGZ|TXZ) For source packages: CPACK_SOURCE_(TGZ|TBZ2|TXZ|TZ|ZIP) For convenience, I'll enable CPACK_SOURCE_TGZ and leave all the other ones disabled by default. CMakeLists.txt (line 89) <https://reviews.apache.org/r/55657/#comment239320> At the moment, there's no need to mirror the autotools target name. So this line can be removed. - Joseph Wu On Jan. 18, 2017, 2:25 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55657/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2017, 2:25 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Bugs: MESOS-4245 > https://issues.apache.org/jira/browse/MESOS-4245 > > > Repository: mesos > > > Description > ------- > > Added cpack to create source package. > > > Diffs > ----- > > CMakeLists.txt c6b1eb6a7c7e6ed3650847acbec0ddd3101bb96f > > Diff: https://reviews.apache.org/r/55657/diff/ > > > Testing > ------- > > > Thanks, > > Srinivas Brahmaroutu > >
