----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56666/#review167170 -----------------------------------------------------------
3rdparty/libprocess/include/process/ssl/utilities.hpp (lines 114 - 122) <https://reviews.apache.org/r/56666/#comment239341> In this comment, it might be good to introduce HMAC by saying "Generates a keyed-hash message authentication code (HMAC) with SHA256." Then, you can use "HMAC" in the `@return` comment below. 3rdparty/libprocess/include/process/ssl/utilities.hpp (lines 124 - 125) <https://reviews.apache.org/r/56666/#comment239344> Could we use `key` instead of `secret` for the second parameter name here? Seems more consistent with the terminology in this file, as well as the OpenSSL library. I also have a slight preference for `message` instead of `input`, but up to you. - Greg Mann On Feb. 27, 2017, 11:37 a.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56666/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2017, 11:37 a.m.) > > > Review request for mesos, Alexander Rojas and Greg Mann. > > > Bugs: MESOS-7001 > https://issues.apache.org/jira/browse/MESOS-7001 > > > Repository: mesos > > > Description > ------- > > HMAC SHA256 can be used to create or verify message signatures. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/ssl/utilities.hpp > c2f64a91a505675d568ddf5aa081125e4e32fe17 > 3rdparty/libprocess/src/ssl/utilities.cpp > 8aec613312eee3dd11d9df8c3828a5185407e073 > > Diff: https://reviews.apache.org/r/56666/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
