----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57158/#review167184 -----------------------------------------------------------
Patch looks great! Reviews applied: [56623, 56617, 56618, 56901, 57054, 57153, 56619, 56812, 56813, 56624, 56621, 57158] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Feb. 28, 2017, 7:28 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57158/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2017, 7:28 p.m.) > > > Review request for mesos, Alexander Rojas and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > The master's validation function for RESERVE operations previously > did not set a default parameter value for its final optional > parameter, requiring callsites to explicitly specify `None()`. This > patch adds the default value. > > > Diffs > ----- > > src/master/http.cpp 6e5178eeea6cc6b90ae253840da22be13444b088 > src/master/validation.hpp f03b3280704083be1ca074ca07c69edbb49dae19 > > Diff: https://reviews.apache.org/r/57158/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >
