----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49223/#review167345 -----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On July 21, 2016, 4:34 p.m., Klaus Ma wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49223/ > ----------------------------------------------------------- > > (Updated July 21, 2016, 4:34 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-5739 > https://issues.apache.org/jira/browse/MESOS-5739 > > > Repository: mesos > > > Description > ------- > > Fixed Value parsing code to only accept the canonical formats. > NOTES: This patch isn't doing a complete validation against > the canonical format yet: the set entries is not validated as > conforming to the Values.Text format yet. > > > Diffs > ----- > > src/common/values.cpp 7b8a8ea00bd4bd1a82c33be4438c26b2731b1dd8 > src/tests/values_tests.cpp cc17b675d5d3768685b44a1cea64264dcbca80ba > src/v1/values.cpp ff1926f9ab26c3ac3ab62b6df3ce305f5d12f12e > > > Diff: https://reviews.apache.org/r/49223/diff/8/ > > > Testing > ------- > > make && make check > > > Thanks, > > Klaus Ma > >
