----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52393/#review167387 -----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On Sept. 29, 2016, 3:50 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52393/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2016, 3:50 p.m.) > > > Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > The content inside of the docker config file specified by the agent > flag '--docker_config' already has to be a JSON object since it is > the type defined for that agent flag. > > However, we should allow malformatted config file existed, instead > of blocking the other images pulling which do not need a credential > to pull images from the non-authenticated registry. In this patch, > if the docker config file is malformatted, we will log a warning > and continue with the assumption that no docker config is provided. > > > Diffs > ----- > > src/uri/fetchers/docker.cpp 3f38dddfb4c089322fe4e13b1ef2070b4835885c > > > Diff: https://reviews.apache.org/r/52393/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
