----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51410/#review167396 -----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On Oct. 16, 2016, 5:58 p.m., Srinivas Brahmaroutu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51410/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2016, 5:58 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-4288 > https://issues.apache.org/jira/browse/MESOS-4288 > > > Repository: mesos > > > Description > ------- > > Added appc_labels to mesos-execute so that we can indicate meta > discovery using useMetaDiscovery="true" along with other appc labels > that determines the os, arch of the image we are discovering. This logic > needs to be documented so that user can switch between simple and meta > discovery methods. This implementation is necessary as there is no other > way to determine from the URI. > > > Diffs > ----- > > src/cli/execute.cpp fcf627b0dcbedd01700cc8c9acadf7ba0dae4faa > src/slave/containerizer/mesos/provisioner/appc/fetcher.hpp > 373c7d4c0c7c4e35ca568f37e52915549798ee32 > src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp > f5e90527e6ace45a7745ca1ba1a9eeef938d2a68 > src/slave/flags.hpp ec619f84c7f3be81db8ce8536936bf7d4207efa2 > src/slave/flags.cpp 7f79cfcc7939680c38a3d0cd57471cc9976aff7c > > > Diff: https://reviews.apache.org/r/51410/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Srinivas Brahmaroutu > >
