----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50492/#review167454 -----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On Nov. 14, 2016, 3:32 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50492/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2016, 3:32 a.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5828 > https://issues.apache.org/jira/browse/MESOS-5828 > > > Repository: mesos > > > Description > ------- > > The logic of log network was added to libprocess under name PIDGroup. > This patch removed Network/NetworkProcess and switched replicated log > to use PIDGroup instead. This is part of the code clean-up and > modularizing PIDGroup abstraction alongside `MasterContender` and > `MasterDetector`. > > > Diffs > ----- > > src/log/catchup.hpp 1e6d4c2d83cc3799084b186f8abd5a3a14c8d8ce > src/log/catchup.cpp 94e1b00db2cd9d5a2368a979c1fd155bb6cac1f2 > src/log/consensus.hpp 37337225d9a60cd3ef6015b122dddbefdeda9147 > src/log/consensus.cpp 94ddf245c07ccd38d4fe828bc47c98ecf540243f > src/log/coordinator.hpp b5f9c962a983af0d591e878d12b7fe8bb59cc867 > src/log/coordinator.cpp 72ef0366633b4e4137fd303fa49f9efb166c80c9 > src/log/log.hpp a600025f4ca38e3fad0f64f48b007138da8e22d4 > src/log/log.cpp 2301eef564f2a42958c6c2c8eef0cc4b2fd76353 > src/log/network.hpp 0afcfae27394527f7c957e31014cc9a32a4bf63b > src/log/recover.hpp 94d6bb283ea82df607fcc72de05cda3b12ad5d2d > src/log/recover.cpp b366818767adb259ee6805f9978fd330b790a264 > src/tests/log_tests.cpp 99954388eb0fad2acde0cedfd7daa3c9379bfb03 > > > Diff: https://reviews.apache.org/r/50492/diff/5/ > > > Testing > ------- > > see the end of review chain > > > Thanks, > > Jay Guo > >
