----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53701/#review167465 -----------------------------------------------------------
Closing this review due to inactivity. Please see our [guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md) for reopening reviews. - Joris Van Remoortere On Nov. 14, 2016, 4:07 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53701/ > ----------------------------------------------------------- > > (Updated Nov. 14, 2016, 4:07 a.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5828 > https://issues.apache.org/jira/browse/MESOS-5828 > > > Repository: mesos > > > Description > ------- > > Since ZooKeeperPIDGroup now holds two `group` objects, more > expressive names are assigned. Also some methods are refactored > to leverage error handlers in case of onFailed/onDiscarded. > > > Diffs > ----- > > src/log/pid_group/zookeeper.hpp PRE-CREATION > src/log/pid_group/zookeeper.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/53701/diff/1/ > > > Testing > ------- > > > Thanks, > > Jay Guo > >
