----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/#review167662 -----------------------------------------------------------
Fix it, then Ship it! src/slave/main.cpp Lines 170 (patched) <https://reviews.apache.org/r/53369/#comment239574> The following is cleaner: ``` Try<Nothing> assignCgroups(const string& subsystems); ``` src/slave/main.cpp Lines 174 (patched) <https://reviews.apache.org/r/53369/#comment239573> Not yours, but move this 1 space to the right. src/slave/main.cpp Lines 380-381 (patched) <https://reviews.apache.org/r/53369/#comment239576> Here we can explain the timing: ``` // Move the agent process into its own cgroup for each of the specified // subsystems before the process is initialized. ``` src/slave/main.cpp Lines 382 (patched) <https://reviews.apache.org/r/53369/#comment239575> ``` if (flags.agent_subsystems.isSome()) { Try<Nothing> assign = assignCgroups(flags.agent_subsystems.get()); if (assign.isError()) { EXIT(EXIT_FAILURE) << assign.error(); } } ``` - Jiang Yan Xu On March 1, 2017, 9:57 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53369/ > ----------------------------------------------------------- > > (Updated March 1, 2017, 9:57 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6523 > https://issues.apache.org/jira/browse/MESOS-6523 > > > Repository: mesos > > > Description > ------- > > This is to ensure that we do not accept traffic on the agent by opening > up libprocess port only after cgroup assigment for the agent is done. > > > Diffs > ----- > > src/slave/main.cpp a124d2e0cfa3e39e2400183f9523486196b9816d > src/slave/slave.cpp 892ce1938ac695e7913aa9139536d0787f3f5ea7 > > > Diff: https://reviews.apache.org/r/53369/diff/3/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
