----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57193/#review167725 -----------------------------------------------------------
Fix it, then Ship it! Looks like you're also handling the case where the webui is communicating with an old (non-MULTI_ROLE capable) agent, which is great! Did you test this manually? Would be good to do a quick manual test to ensure it works. src/webui/master/static/agent.html Lines 155 (patched) <https://reviews.apache.org/r/57193/#comment239644> How about a TODO here? ``` TODO(guoger): This doesn't display well when there are a lot of roles (e.g. a large organization with a lof of teams & services, using roles like /engineering/frontend/webserver). Figure out a way to display this without bloating the table. ``` src/webui/master/static/agent.html Lines 196 (patched) <https://reviews.apache.org/r/57193/#comment239645> Ditto here. src/webui/master/static/agent_framework.html Lines 26 (patched) <https://reviews.apache.org/r/57193/#comment239646> Ditto here, something like: ``` TODO(guoger): Consider having a break between each role. Also, this doesn't display well when there are a lot of roles (e.g. a large organization with a lof of teams & services, using roles like /engineering/frontend/webserver). ``` src/webui/master/static/js/controllers.js Lines 697-700 (patched) <https://reviews.apache.org/r/57193/#comment239648> Is this accurate? It seems to me this occurs only when hitting the state endpoint of an old agent. New agents will always populate the role field in the json, no? src/webui/master/static/js/controllers.js Lines 780-782 (patched) <https://reviews.apache.org/r/57193/#comment239671> Ditto here, this happens when talking to an old agent, right? - Benjamin Mahler On March 2, 2017, 3:34 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57193/ > ----------------------------------------------------------- > > (Updated March 2, 2017, 3:34 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-6657 > https://issues.apache.org/jira/browse/MESOS-6657 > > > Repository: mesos > > > Description > ------- > > Updated WebUI to display role information under tab 'Agents'. > > > Diffs > ----- > > src/webui/master/static/agent.html 416e6c2c7e52937e02f8a4237852b84116f2526a > src/webui/master/static/agent_executor.html > 95e921d1c3ca0f005e3eb3f79eb0d9a70a3b3f91 > src/webui/master/static/agent_framework.html > 806ab06063dcf62cd6d1d7913840ed83141bd1eb > src/webui/master/static/js/controllers.js > 2ea8275cb5fffa2344474ebfcf9277fe92165a92 > > > Diff: https://reviews.apache.org/r/57193/diff/2/ > > > Testing > ------- > > > File Attachments > ---------------- > > Page Agents/Frameworks > > https://reviews.apache.org/media/uploaded/files/2017/03/01/8e943f7b-bcc0-43ac-9539-eeefd6f49359__Screen_Shot_2017-03-01_at_18.26.07.png > Page Agents/Frameworks/Executors > > https://reviews.apache.org/media/uploaded/files/2017/03/01/8eac0e06-6663-4662-85ef-f4755dc1b1cb__Screen_Shot_2017-03-01_at_18.26.48.png > Page Agents/Frameworks/Executors/Tasks > > https://reviews.apache.org/media/uploaded/files/2017/03/01/c66210d4-1826-49c5-93d8-4bd224112ff8__Screen_Shot_2017-03-01_at_18.27.20.png > > > Thanks, > > Jay Guo > >
