----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56813/#review167754 -----------------------------------------------------------
src/master/http.cpp Lines 841-845 (original), 844-851 (patched) <https://reviews.apache.org/r/56813/#comment239698> CHECK(principal->value.isSome())? src/master/http.cpp Lines 1823-1825 (original), 1812-1814 (patched) <https://reviews.apache.org/r/56813/#comment239700> Consider: Option<Subject> subject = createSubject(principal) if (subject.isSome()) { authRequest.mutable_subject()->CopyFrom(subject.get); } src/master/master.hpp Line 746 (original), 746 (patched) <https://reviews.apache.org/r/56813/#comment239701> See if we can typedef this. src/master/master.cpp Lines 1565-1573 (original), 1569-1577 (patched) <https://reviews.apache.org/r/56813/#comment239703> CHECK(principal->value.isSome()) src/master/master.cpp Lines 1608-1611 (original), 1612-1615 (patched) <https://reviews.apache.org/r/56813/#comment239704> Rework to make more readable src/master/master.cpp Lines 3499-3501 (original), 3503-3504 (patched) <https://reviews.apache.org/r/56813/#comment239705> s/ANY/'ANY'/ src/master/master.cpp Line 3537 (original), 3540 (patched) <https://reviews.apache.org/r/56813/#comment239706> s/entity/principal/ src/master/master.cpp Line 3553 (original), 3556 (patched) <https://reviews.apache.org/r/56813/#comment239707> 'ANY' src/master/master.cpp Line 3605 (original), 3607 (patched) <https://reviews.apache.org/r/56813/#comment239708> 'ANY' src/master/quota_handler.cpp Line 379 (original), 383 (patched) <https://reviews.apache.org/r/56813/#comment239709> CHECK_SOME(principal->value) src/master/quota_handler.cpp Line 541 (original), 545 (patched) <https://reviews.apache.org/r/56813/#comment239710> s/entity/principal src/master/quota_handler.cpp Line 542 (original), 546 (patched) <https://reviews.apache.org/r/56813/#comment239711> 'ANY' src/master/quota_handler.cpp Lines 571-572 (original), 575-576 (patched) <https://reviews.apache.org/r/56813/#comment239712> principal 'ANY' src/master/quota_handler.cpp Lines 599-600 (original), 603-604 (patched) <https://reviews.apache.org/r/56813/#comment239713> principal 'ANY' src/master/weights_handler.cpp Lines 323-324 (original), 327-328 (patched) <https://reviews.apache.org/r/56813/#comment239714> principal 'ANY' src/master/weights_handler.cpp Line 366 (original), 370 (patched) <https://reviews.apache.org/r/56813/#comment239715> principal 'ANY' - Greg Mann On Feb. 28, 2017, 6:34 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56813/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2017, 6:34 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7003 > https://issues.apache.org/jira/browse/MESOS-7003 > > > Repository: mesos > > > Description > ------- > > This patch updates the HTTP endpoint handlers in the > master process to accept the `Principal` type instead > of an `Option<string>& principal`. > > > Diffs > ----- > > src/master/http.cpp 6e5178eeea6cc6b90ae253840da22be13444b088 > src/master/master.hpp 764adb18ddf09b62529c5c96f8e4dfaf7803483e > src/master/master.cpp 2ef836536784d5fda23c80dc2304239b176a8942 > src/master/quota_handler.cpp 3ad28e4a9363a877d0610b529a6c17fb30ece37a > src/master/registrar.cpp d7134eea34102ab7b24d2f0131363bdd9005cfd3 > src/master/weights_handler.cpp 4f6a4cd29d27b64cbc9ee6d8909f79812313b681 > > > Diff: https://reviews.apache.org/r/56813/diff/6/ > > > Testing > ------- > > Testing details can be found at the end of this review chain. > > > Thanks, > > Greg Mann > >
