----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57260/#review167774 -----------------------------------------------------------
Ship it! Ship It! - Andrew Schwartzmeyer On March 2, 2017, 11:53 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57260/ > ----------------------------------------------------------- > > (Updated March 2, 2017, 11:53 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Alex Clemmer, and Joris Van > Remoortere. > > > Bugs: MESOS-6691 > https://issues.apache.org/jira/browse/MESOS-6691 > > > Repository: mesos > > > Description > ------- > > The logic to find APR and SVN headers/libraries are effectively the > same, except for where those headers/libraries might be found. > > This commit refactors the two files into a helper that takes several > lists as arguments (lists are passed by reference in CMake) and > outputs two lists of directories. > > This also removes the logic for finding `APR-util`, which is not > used in this project. > > > Diffs > ----- > > 3rdparty/stout/cmake/FindApr.cmake 13156a58a57c22044977c7220df31372e61f82f6 > 3rdparty/stout/cmake/FindPackageHelper.cmake PRE-CREATION > 3rdparty/stout/cmake/FindSvn.cmake d57eed98285295bcc845bb0494c86e3866685690 > > > Diff: https://reviews.apache.org/r/57260/diff/1/ > > > Testing > ------- > > cmake .. > > > Thanks, > > Joseph Wu > >
