> On March 1, 2017, 8:24 a.m., Greg Mann wrote: > > 3rdparty/libprocess/src/jwt.cpp > > Lines 94-95 (patched) > > <https://reviews.apache.org/r/56667/diff/4/?file=1645869#file1645869line94> > > > > Join on one line: > > > > `} else if ( ... ) {` > > > > Could also use a `switch` statement here instead.
Sorry, can't `switch` a string in C++ :( - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56667/#review167186 ----------------------------------------------------------- On March 3, 2017, 3:03 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56667/ > ----------------------------------------------------------- > > (Updated March 3, 2017, 3:03 p.m.) > > > Review request for mesos, Alexander Rojas and Greg Mann. > > > Bugs: MESOS-7001 > https://issues.apache.org/jira/browse/MESOS-7001 > > > Repository: mesos > > > Description > ------- > > JSON Web Tokens can be used to create claim-based access tokens and is > typically used for HTTP authentication. > This implementation is intended for internal use, e.g. Mesos is supposed > to only parse tokens that it also created. It doesn't fully comply with > RFC 7519. Currently the only supported cryptographic algorithm is HMAC > with SHA-256. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 75386184108214e67a58c328258ec204099d638c > 3rdparty/libprocess/include/process/jwt.hpp PRE-CREATION > 3rdparty/libprocess/src/jwt.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/jwt_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/56667/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
