> On Nov. 2, 2016, 5:08 a.m., Jie Yu wrote: > > The agent subsystems is a hack to me. I think we should consider support > > running systemd (or other init system) to manage agent process and put it > > under proper cgroup using the init system, rather than doing it ourself. > > Anindya Sinha wrote: > Agreed. But since this flag exists, I think we should address this > condition? Or are you suggesting to deprecate this flag? > > Jiang Yan Xu wrote: > @Jie > > If you are talking about the Mesos core, I think it already supports > being run by systemd? If you are talking about supporting > scripts/configs/packaging, then I agree the project can potentially do more > but that's a longer term goal towards better user experience of "stock" Mesos > packages. > > In the meantime, the flag has been here for a long time and we'd like to > fix this bug with it. Sounds good? > > Jiang Yan Xu wrote: > We picked this one up again. I agree that this doesn't feel like the > cleanest implementation but even if we deprecate it, IMO it's still a bug > that's worth fixing. > > Jie Yu wrote: > Having this fix sounds fine, but I'd like to see follow up actions to > deprecated the agent_subsystems flag and emails to dev list about that. Do > you guys have cycles to drive this? > > Jiang Yan Xu wrote: > Probably not at the moment but happy to JIRA it. I personally don't have > a strong feeling that we need to take it away immediately without > replacement. As I commented above, we don't have good support for such sample > configs and packaging (and it's a long standing issue) so this code at least > in a limited way can be useful to some people. (We could've used it if not > for this bug). > > Thought? > > Jie Yu wrote: > Curious if you haven't used it yet, why not use the preferred way (config > systemd properly)? > > Jiang Yan Xu wrote: > We are fixing it just because it's a bug and it doesn't take much (at the > risk to complicating the codebase) to fix it and not because we couldn't use > alternative mechanisms. (We do) > > I am just being cautious about taking it away from people (we know it's > actually used). But it doesn't affect us if someone goes ahead and do it. :)
OK, sounds good. Can you create a JIRA to track the deprecation of this flag? - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53369/#review154512 ----------------------------------------------------------- On March 3, 2017, 6:07 a.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53369/ > ----------------------------------------------------------- > > (Updated March 3, 2017, 6:07 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6523 > https://issues.apache.org/jira/browse/MESOS-6523 > > > Repository: mesos > > > Description > ------- > > This is to ensure that we do not accept traffic on the agent by opening > up libprocess port only after cgroup assigment for the agent is done. > > > Diffs > ----- > > src/slave/main.cpp a124d2e0cfa3e39e2400183f9523486196b9816d > src/slave/slave.cpp 6ae9458cc81a7623a1837cd636156434a972004b > > > Diff: https://reviews.apache.org/r/53369/diff/5/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
