----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56619/#review167901 -----------------------------------------------------------
Ship it! Ship It! - Vinod Kone On Feb. 28, 2017, 6:32 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56619/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2017, 6:32 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Jan Schlicht, Till > Toenshoff, and Vinod Kone. > > > Bugs: MESOS-7003 > https://issues.apache.org/jira/browse/MESOS-7003 > > > Repository: mesos > > > Description > ------- > > This patch updates the HTTP endpoint handlers in the > Mesos `Files` process to accept the `Principal` type > instead of an `Option<string>& principal`. > > > Diffs > ----- > > src/files/files.hpp 8cffc26fc7d674187e55663f23f1e10bed40229e > src/files/files.cpp 8327f8002fbfa3be77a4bbe4aa83a73d0f170f7a > > > Diff: https://reviews.apache.org/r/56619/diff/8/ > > > Testing > ------- > > Testing information can be found at the end of this review chain. > > > Thanks, > > Greg Mann > >