> On March 3, 2017, 5:58 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 429-432 (original), 394-400 (patched) > > <https://reviews.apache.org/r/57111/diff/1/?file=1650790#file1650790line431> > > > > Ditto from last review, could we simplify with a - operator in > > stout/set.hpp? > > > > ``` > > const set<string> removedRoles = oldRoles - newRoles; > > ```
Replied in the previous patch. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57111/#review167882 ----------------------------------------------------------- On Feb. 27, 2017, 2:20 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57111/ > ----------------------------------------------------------- > > (Updated Feb. 27, 2017, 2:20 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-6627 > https://issues.apache.org/jira/browse/MESOS-6627 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > d33306745a7287b750cb4a5242c7527369d58d65 > src/master/allocator/mesos/hierarchical.cpp > eeb44fe89d4bfd26900b11833c1182157e5c7e5c > > > Diff: https://reviews.apache.org/r/57111/diff/1/ > > > Testing > ------- > > > Thanks, > > Michael Park > >