----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56805/#review168076 -----------------------------------------------------------
Ship it! Ship It! - Adam B On Feb. 28, 2017, 12:24 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56805/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2017, 12:24 p.m.) > > > Review request for mesos, Adam B and Yongqiao Wang. > > > Repository: mesos > > > Description > ------- > > Now that weights can change dynamically, passing a list of weights to > the allocator at initialization-time is unnecessary and confusing (e.g., > the initial weights might be wrong, if a different set of weight values > are recovered from the registry). > > Instead, require that weights are communicated to the allocator via the > existing `updateWeights` method. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp > 25ed5f36b186f2bd257dd0bdb366d0b21a795622 > src/master/allocator/mesos/allocator.hpp > 1defb59b686c9cd8d403a0ed6825219f62a7801d > src/master/allocator/mesos/hierarchical.hpp > 0bb24be2761bde6d1baad69f5654029f3ceed553 > src/master/allocator/mesos/hierarchical.cpp > 696815795dc391b4ec7538892b1224b812482d34 > src/master/master.cpp ae36bf477851bf2fe11eb7913c580e3e0b9cbbe5 > src/tests/allocator.hpp b6b0022d581bd688900aaf5beb0af7ce6e0129a1 > src/tests/api_tests.cpp 607392ff6b714a9e812c2802f4d1465e8f71ad09 > src/tests/hierarchical_allocator_tests.cpp > cdf1f15b7802439b28405ca8f6634ce83e886630 > src/tests/master_allocator_tests.cpp > 7b0b786f1c6c53616fd7ae1f7f765752d94a4f83 > src/tests/master_quota_tests.cpp 91219d6693fdd119ed3b0bf734eaa55da9c58b0a > src/tests/persistent_volume_endpoints_tests.cpp > 1cc6c9d01a3a473f5a44210ea725310ea5931ff6 > src/tests/reservation_endpoints_tests.cpp > 345f0457ec1fc00b7033d71227ff178c14e015bb > src/tests/reservation_tests.cpp 5c0d01483efb4561b8c0016c3a2fa6ea5574196e > src/tests/resource_offers_tests.cpp > 74dacf140e49e402a4ad02ce7751e7c7b2f78ee1 > src/tests/slave_recovery_tests.cpp b5b805868bed61bf482d71322fb1918a0d020d48 > > > Diff: https://reviews.apache.org/r/56805/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
