> On March 7, 2017, 6:38 a.m., Benjamin Mahler wrote: > > src/tests/master_tests.cpp > > Lines 4292-4293 (patched) > > <https://reviews.apache.org/r/57269/diff/1/?file=1655331#file1655331line4292> > > > > Are you planning to test the agent endpoint as well?
I modified existing test to include this https://github.com/apache/mesos/blob/master/src/tests/slave_tests.cpp#L1645-L1663 do you think that's no sufficient? > On March 7, 2017, 6:38 a.m., Benjamin Mahler wrote: > > src/tests/master_tests.cpp > > Lines 4356 (patched) > > <https://reviews.apache.org/r/57269/diff/1/?file=1655331#file1655331line4356> > > > > Can you do a sweep for using the -> operator in this test? Fixed in a separate patch: https://reviews.apache.org/r/57360/ - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57269/#review168058 ----------------------------------------------------------- On March 7, 2017, 11:35 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57269/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 11:35 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7158 > https://issues.apache.org/jira/browse/MESOS-7158 > > > Repository: mesos > > > Description > ------- > > This test ensures that allocation roles of tasks and executors are > exposed via `/state` endpoint of master v0 API. > > > Diffs > ----- > > src/tests/master_tests.cpp b9dfe9eb7d759550673896980cffc3909f4c0105 > > > Diff: https://reviews.apache.org/r/57269/diff/2/ > > > Testing > ------- > > Added a test `MasterTest.StateEndpointAllocationRole` > > make check > > > Thanks, > > Jay Guo > >
