> On Dec. 27, 2016, 1:48 p.m., Till Toenshoff wrote: > > This sums up the following changes on `atomic_pointer.h` done within the > > upstream project; > > https://github.com/google/leveldb/commit/803d69203a62faf50f1b77897310a3a1fcae712b > > https://github.com/google/leveldb/commit/c4c38f9c1f3bb405fe22a79c5611438f91208d09 > > https://github.com/google/leveldb/commit/ceff6f12152785a54885a47db349a6d8dfd0ce2c > > > > Note that some of those changes are unrelated to ARM64 and hence not > > strictly within the scope > > of this ticket -- so we do not need those changes. However, having things > > in sync with upstream > > is definitely valuable and in these specific cases appears to be free of > > additional risks.
Should we close this now that LevelDB has been upgraded to 1.19? - Aaron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54993/#review160160 ----------------------------------------------------------- On Dec. 22, 2016, 9:10 p.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54993/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2016, 9:10 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6834 > https://issues.apache.org/jira/browse/MESOS-6834 > > > Repository: mesos > > > Description > ------- > > Mesos will not compile on ARM64/AArch64 without a patch to the version of > LevelDB that is used within Mesos. While the fix is already in newer versions > of LevelDB it's not something that Mesos pulls down. > > The main issue is that the AtomicPointer header needs to be aware of other > architectures to provide its functionality to those architectures. > > > Diffs > ----- > > 3rdparty/leveldb-1.4.patch b899f0141 > > > Diff: https://reviews.apache.org/r/54993/diff/1/ > > > Testing > ------- > > Compiled Mesos on ARM64 with no failures. Mesos also properly starts and > successfully runs/launches tasks with the exception of a crash when using the > linux_launcher and Mesos containers. That fix is addressed in > https://reviews.apache.org/r/54996/ > > > Thanks, > > Aaron Wood > >
