----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56757/#review168358 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/authentication/secret_generator.hpp Lines 32 (patched) <https://reviews.apache.org/r/56757/#comment240573> s/a HTTP/an HTTP/ include/mesos/module/secret_generator.hpp Lines 20 (patched) <https://reviews.apache.org/r/56757/#comment240577> I think you should also include `<mesos/mesos.hpp>` here, for `Parameters`. include/mesos/module/secret_generator.hpp Lines 30 (patched) <https://reviews.apache.org/r/56757/#comment240575> Looks like the existing pattern is to not include whitespace in the 'kind', see for example 'QosController', 'ResourceEstimator' - Greg Mann On March 8, 2017, 2:25 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56757/ > ----------------------------------------------------------- > > (Updated March 8, 2017, 2:25 p.m.) > > > Review request for mesos, Alexander Rojas and Greg Mann. > > > Bugs: MESOS-6997 > https://issues.apache.org/jira/browse/MESOS-6997 > > > Repository: mesos > > > Description > ------- > > This interface will be used by agents to create credentials for the > default executor. > > > Diffs > ----- > > include/mesos/authentication/secret_generator.hpp PRE-CREATION > include/mesos/module/secret_generator.hpp PRE-CREATION > src/Makefile.am bb917c5d1b36f5106a74914fa3a864038a95e8bb > > > Diff: https://reviews.apache.org/r/56757/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
