> On März 2, 2017, 11:12 nachm., Neil Conway wrote: > > src/tests/role_tests.cpp > > Lines 887 (patched) > > <https://reviews.apache.org/r/57190/diff/1/?file=1652615#file1652615line887> > > > > We can't depend on `ls` and `grep` being available on Windows. > > > > We could write the test with `#ifdef`s, although that seems > > unfortunate. Not sure there's a better alternative, given the current agent > > volume creation logic... > > Benjamin Bannier wrote: > I'll see if this can be implemented with `test` and some globbing.
I wasn't successfully in populate an array with the directory listing with globbing (the `grep` part can be replaced by getting the length of the array then). I have disabled the test for now. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57190/#review167297 ----------------------------------------------------------- On März 10, 2017, 12:14 vorm., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57190/ > ----------------------------------------------------------- > > (Updated März 10, 2017, 12:14 vorm.) > > > Review request for mesos, Benjamin Mahler, Michael Park, and Neil Conway. > > > Bugs: MESOS-7047 > https://issues.apache.org/jira/browse/MESOS-7047 > > > Repository: mesos > > > Description > ------- > > This commit adjusts the way persistent volumes are stored on the > agent. Instead of interpreting the role of the volume as a literal > path, we replace `/` with ` ` when creating the path. This prevents > that subdirectories are created for volumes with hierarchical roles. > Directly interpreting the role as a path is undesirable as it can lead > to volumes overlapping (e.g., a volume with role `a/b/c/d` and id `id` > would be visible as `id` in a volume with role `a/b/c` and id `d`). > > > Diffs > ----- > > src/slave/paths.cpp 38ad1993aa36a627ec97a7865488677495ee4c5a > src/tests/role_tests.cpp 77f3d46a544a51ba71476e2f0735bb32758dd9e1 > > > Diff: https://reviews.apache.org/r/57190/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Bannier > >
