----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57384/#review168650 -----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp Lines 2403 (patched) <https://reviews.apache.org/r/57384/#comment240889> I think this behaviour should be called out in the comments in the header because it's not intuitive. Ideally we should be able to definitively say whether its sandbox directory is gone, but I guess it's not easy. Runtime directory existence check seems straightforward. - Vinod Kone On March 10, 2017, 5:58 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57384/ > ----------------------------------------------------------- > > (Updated March 10, 2017, 5:58 p.m.) > > > Review request for mesos, Alexander Rukletsov, Jie Yu, Kevin Klues, and Vinod > Kone. > > > Bugs: MESOS-7120 > https://issues.apache.org/jira/browse/MESOS-7120 > > > Repository: mesos > > > Description > ------- > > This new method removes the sandbox and runtime directories of a > terminated nested container. > > > Diffs > ----- > > src/slave/containerizer/containerizer.hpp > f65a9b9761fc254bd0778bf13aac9b256497b22f > src/slave/containerizer/mesos/containerizer.hpp > 09f94ccb3224c14a9324961b789455b119ec2257 > src/slave/containerizer/mesos/containerizer.cpp > 7676a4d8a35f2239c7373b0a9e76fa343b322f62 > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > ea01fe55a28d17105157004d8cf0976202a49b7c > > > Diff: https://reviews.apache.org/r/57384/diff/4/ > > > Testing > ------- > > Added a test and verified that it works on Linux. > > > Thanks, > > Gastón Kleiman > >
