> On March 14, 2017, 7:03 a.m., Benjamin Mahler wrote: > > Looks good, the changes to resources.cpp were done how? Are they a direct > > reversion to the old code?
Yes, I did a `git revert` and apply changes based on that. > On March 14, 2017, 7:03 a.m., Benjamin Mahler wrote: > > src/common/protobuf_utils.hpp > > Lines 126-128 (original), 126-128 (patched) > > <https://reviews.apache.org/r/57340/diff/1/?file=1656720#file1656720line126> > > > > I like the naming you used for the strip function, mind also clarifying > > the naming of this one in a separate patch? > > > > ``` > > void injectAllocationInfo( > > Offer::Operation* operation, > > const Resource::AllocationInfo& allocationInfo); > > ``` Will do. - Jay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57340/#review168539 ----------------------------------------------------------- On March 15, 2017, 1:39 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57340/ > ----------------------------------------------------------- > > (Updated March 15, 2017, 1:39 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7048 > https://issues.apache.org/jira/browse/MESOS-7048 > > > Repository: mesos > > > Description > ------- > > Remove adjustment code within Resources::apply. > > > Diffs > ----- > > src/common/protobuf_utils.hpp 09e468c77f0cdd931302d1bdcc192370b6ce3340 > src/common/protobuf_utils.cpp 34c14e8ebd7b575627704c7edebcbb0458eeb3b1 > src/common/resources.cpp 388e3ef3eabea0dd8d1300e56d493b92b70c75e3 > src/master/allocator/mesos/hierarchical.cpp > 37fb7a62ef95c2f6e5a9e9a4ab49260332e2b03b > src/master/master.cpp d43350d08ddd14fb7ba2a79c899abda6a864038c > src/tests/resources_tests.cpp 5ffc9e7111c91157b79a38a1cbd8d58a0565e450 > src/v1/resources.cpp e47c4d49e69b915d37e40a91fef69f75dff52463 > > > Diff: https://reviews.apache.org/r/57340/diff/2/ > > > Testing > ------- > > WIP > > > Thanks, > > Jay Guo > >
