----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56475/#review168925 -----------------------------------------------------------
Patch looks great! Reviews applied: [56474, 56476, 56475] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 14, 2017, 10:07 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56475/ > ----------------------------------------------------------- > > (Updated March 14, 2017, 10:07 a.m.) > > > Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and > Vinod Kone. > > > Bugs: MESOS-7004 > https://issues.apache.org/jira/browse/MESOS-7004 > > > Repository: mesos > > > Description > ------- > > This patch adds a unit test to verify the functionality of > the `CombinedAuthenticator`. The new test is called > `CombinedAuthenticatorTest.MultipleAuthenticators`. > > > Diffs > ----- > > src/tests/http_authentication_tests.cpp > 0eeed9d19881cf3fa5fec7fb7fedc1e92784f58b > > > Diff: https://reviews.apache.org/r/56475/diff/5/ > > > Testing > ------- > > The following commands were used to test: > `make check` > `bin/mesos-tests.sh --gtest_filter="*CombinedAuthenticator*" > --gtest_repeat=-1 --gtest_break_on_failure` > > > Thanks, > > Greg Mann > >