----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57490/#review168928 -----------------------------------------------------------
Ship it! LGTM! Verified a couple of artificially added CHECK failures in stout, libprocess, and Mesos all stacktraced. Followup for stacktraces on segfaults: https://issues.apache.org/jira/browse/MESOS-7245 - Joseph Wu On March 9, 2017, 5:59 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57490/ > ----------------------------------------------------------- > > (Updated March 9, 2017, 5:59 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-6815 > https://issues.apache.org/jira/browse/MESOS-6815 > > > Repository: mesos > > > Description > ------- > > This relies on an updated `glog-da816ea70.tar.gz` tarball > in the Mesos 3rdparty repository, and a patch generated between > it and the `windows-stacktrace` branch (and pull request) made > to Glog. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 5fbe178c3d4335bb30c5b955fbde8861648c0496 > 3rdparty/glog-da816ea70.patch PRE-CREATION > > > Diff: https://reviews.apache.org/r/57490/diff/1/ > > > Testing > ------- > > Run CTest. > > > Thanks, > > Andrew Schwartzmeyer > >
