> On March 15, 2017, 9:51 a.m., Vinod Kone wrote: > > src/launcher/executor.cpp > > Lines 886 (patched) > > <https://reviews.apache.org/r/57596/diff/1/?file=1663400#file1663400line887> > > > > Add a comment to signify what this boolean captures.
Hmmm, I thought I could spare a comment since it seemed rather obvious. But I'll add one if you think it adds value. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57596/#review168976 ----------------------------------------------------------- On March 14, 2017, 2:08 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57596/ > ----------------------------------------------------------- > > (Updated March 14, 2017, 2:08 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-6906 > https://issues.apache.org/jira/browse/MESOS-6906 > > > Repository: mesos > > > Description > ------- > > Prior to this patch, command executor wipes TaskInfo after receiving > a status update acknowledgement from the scheduler to indicate that > there are no unacknowledged tasks. Keeping original TaskInfo beyond > the ack can be beneficial, hence we introduce a struct TaskData that > holds TaskInfo and explicit ack flag. > > > Diffs > ----- > > src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378 > > > Diff: https://reviews.apache.org/r/57596/diff/1/ > > > Testing > ------- > > See https://reviews.apache.org/r/56213/ > > > Thanks, > > Alexander Rukletsov > >
