> On March 15, 2017, 10:04 a.m., Vinod Kone wrote: > > src/checks/checker.cpp > > Lines 436-438 (patched) > > <https://reviews.apache.org/r/57597/diff/1/?file=1663405#file1663405line436> > > > > Why is this comment here and not in the CheckInfo proto like you did > > with Executor Failure? > > > > Also, the first statement looks very similar to what you have in > > executor failure. Can you explicitly say that we return the result of > > `WEXITSTATUS` here?
Let's have both! Can be valuable until after MESOS-7242 is resolved. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57597/#review168978 ----------------------------------------------------------- On March 14, 2017, 2:09 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57597/ > ----------------------------------------------------------- > > (Updated March 14, 2017, 2:09 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/scheduler/scheduler.proto > d04924a49d0bf28952af6cb72d972cac61e6f781 > include/mesos/v1/scheduler/scheduler.proto > 6e8246da0af9097b6fd2fe7c9c15fc4bdc9e4fce > src/checks/checker.cpp 8716e4cc684e6c4b6b76d8ca53221be06d10b2a6 > > > Diff: https://reviews.apache.org/r/57597/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Alexander Rukletsov > >
