----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56474/#review168905 -----------------------------------------------------------
src/authentication/http/combined_authenticator.cpp Lines 146 (patched) <https://reviews.apache.org/r/56474/#comment241191> call this `extractUnauthorizedHeaders` ? src/authentication/http/combined_authenticator.cpp Lines 345 (patched) <https://reviews.apache.org/r/56474/#comment241192> new line. include/mesos/authentication/http/combined_authenticator.hpp Lines 123-130 (patched) <https://reviews.apache.org/r/56474/#comment241331> why do we need the `overrides`? do we expect devs to subclass this in the future? src/authentication/http/combined_authenticator.cpp Lines 237-240 (patched) <https://reviews.apache.org/r/56474/#comment241334> You could've done ``` combinedResult.unauthorized = Unauthorized( extractUnauthorizedHeaders(results), strings::join("\n\n", extractUnauthorizedBodies(results))); ``` provided `extractUnauthorizedHeaders` returned a vector. can the extract functions return a vector instead of list? - Vinod Kone On March 14, 2017, 9:36 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56474/ > ----------------------------------------------------------- > > (Updated March 14, 2017, 9:36 p.m.) > > > Review request for mesos, Alexander Rojas, Jan Schlicht, Till Toenshoff, and > Vinod Kone. > > > Bugs: MESOS-7004 > https://issues.apache.org/jira/browse/MESOS-7004 > > > Repository: mesos > > > Description > ------- > > This patch adds a new default authenticator, the > `CombinedAuthenticator`, which can load multiple authenticators. > It calls installed authenticators serially, returning the first > successful result. When no results are successful, it returns a > single result obtained by merging all unsuccessful results. > > > Diffs > ----- > > include/mesos/authentication/http/combined_authenticator.hpp PRE-CREATION > src/CMakeLists.txt e1f81a17c0b007e84a5fc9827ef6b90bc276c267 > src/Makefile.am 2eea11a4f18f5d0e4ac3cc6bffc8b80f00556d01 > src/authentication/http/combined_authenticator.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/56474/diff/8/ > > > Testing > ------- > > Testing information can be found in the subsequent patch in this chain. > > > Thanks, > > Greg Mann > >
