----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57645/#review169130 -----------------------------------------------------------
src/checks/health_checker.cpp Lines 278-281 (patched) <https://reviews.apache.org/r/57645/#comment241451> AFAICT, this is called synchronously, so the callers can ensure they are not calling it while paused. having if check here but not in `success` is also a bit confusing. src/checks/health_checker.cpp Lines 375 (patched) <https://reviews.apache.org/r/57645/#comment241450> src/checks/health_checker.cpp Lines 381-386 (patched) <https://reviews.apache.org/r/57645/#comment241448> this looks like a unrelated change? src/checks/health_checker.cpp Lines 928 (patched) <https://reviews.apache.org/r/57645/#comment241449> log message? more importantly, AFAICT `scheduleNext` is called synchronously from other functions so that callers can ensure they are not calling it when paused. so this can be a CHECK. - Vinod Kone On March 15, 2017, 2:59 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57645/ > ----------------------------------------------------------- > > (Updated March 15, 2017, 2:59 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, and Vinod Kone. > > > Bugs: MESOS-6280 > https://issues.apache.org/jira/browse/MESOS-6280 > > > Repository: mesos > > > Description > ------- > > See the summary. > > > Diffs > ----- > > src/checks/health_checker.hpp f1f2834b3429fb00cc49c179fa9a3de328f597b5 > src/checks/health_checker.cpp 6c97369fd9a567ba16dd92085bf142d43f71eaf1 > src/docker/executor.cpp 6c11320fc40ba1eebdbdf95f0a52ac383646d9f8 > src/launcher/default_executor.cpp 0ed436faa68e984d0be4e5186138f738bc7f1b52 > src/launcher/executor.cpp adcc50fb7df91b9f8dff0f583b61e0efcd6da378 > > > Diff: https://reviews.apache.org/r/57645/diff/1/ > > > Testing > ------- > > `make check` in Linux > > > Thanks, > > Gastón Kleiman > >
