----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57647/#review169135 -----------------------------------------------------------
src/checks/health_checker.hpp Lines 197 (patched) <https://reviews.apache.org/r/57647/#comment241462> s/removePreviousCheckContainer/removeNestedContainer/ src/checks/health_checker.hpp Lines 242 (patched) <https://reviews.apache.org/r/57647/#comment241463> container src/checks/health_checker.cpp Line 546 (original), 557 (patched) <https://reviews.apache.org/r/57647/#comment241464> don't think we need "check-" prefix anymore. src/checks/health_checker.cpp Lines 626-628 (patched) <https://reviews.apache.org/r/57647/#comment241465> this can be chained to the above future directly instead of on the copy? src/checks/health_checker.cpp Lines 818-819 (patched) <https://reviews.apache.org/r/57647/#comment241467> hmm. instead of storing the previous container in a member variable and calling `removePreviousCheckContainer` why not do this as part of `.onAny` callback on the `nestedCommandCheck()` future? the removal of the previous container need not block the launch of the next container right? src/checks/health_checker.cpp Lines 857 (patched) <https://reviews.apache.org/r/57647/#comment241466> same comments as previous review regarding promise. - Vinod Kone On March 15, 2017, 2:59 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57647/ > ----------------------------------------------------------- > > (Updated March 15, 2017, 2:59 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, and Vinod Kone. > > > Bugs: MESOS-6280 > https://issues.apache.org/jira/browse/MESOS-6280 > > > Repository: mesos > > > Description > ------- > > See the summary. > > > Diffs > ----- > > src/checks/health_checker.hpp f1f2834b3429fb00cc49c179fa9a3de328f597b5 > src/checks/health_checker.cpp 6c97369fd9a567ba16dd92085bf142d43f71eaf1 > > > Diff: https://reviews.apache.org/r/57647/diff/1/ > > > Testing > ------- > > `make check` in Linux > > > Thanks, > > Gastón Kleiman > >
