----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57167/ -----------------------------------------------------------
(Updated March 16, 2017, 4:53 p.m.) Review request for mesos and Michael Park. Changes ------- Fix typo in comment. Repository: mesos Description ------- The quota'd resources for a nested role are "included" within the quota'd resources for that role's parent. Hence, the quota of a node must always be greater than or equal to the sum of the quota'd resources of that role's children. When creating and removing quota, we must ensure that this invariant is not violated. When computing the cluster capacity heuristic, we must ensure that we do not "double-count" quota'd resources: e.g., if the cluster has a total capacity of 100 CPUs, role "x" has a quota guarantee of 80 CPUs, and role "x/y" has a quota guarantee of 40 CPUs, this does NOT violate the cluster capacity heuristic. Diffs (updated) ----- src/master/quota_handler.cpp 36ea1acca47014b2fb7a3b597b857c8ec9e2ab67 src/tests/hierarchical_allocator_tests.cpp dce619ec49db480685deb1bf8f7faeebe02e25b5 src/tests/master_quota_tests.cpp e418f22ea1773f4356ced44b8d57a80e826c8837 Diff: https://reviews.apache.org/r/57167/diff/5/ Changes: https://reviews.apache.org/r/57167/diff/4-5/ Testing ------- `make check` Thanks, Neil Conway
