> On March 16, 2017, 6:38 p.m., Jie Yu wrote: > > src/tests/utils.hpp > > Line 83 (original), 84 (patched) > > <https://reviews.apache.org/r/57628/diff/1/?file=1664908#file1664908line84> > > > > 2 lines apart. Can you fix this style issue in this file in a separate > > patch?
Will do. > On March 16, 2017, 6:38 p.m., Jie Yu wrote: > > src/tests/utils.cpp > > Lines 187 (patched) > > <https://reviews.apache.org/r/57628/diff/1/?file=1664909#file1664909line187> > > > > Let's follow up with a patch to use this funciton in the CNI isolator > > test and kill the same method in the test fixture. Already removed the corresponding code in the CNI Isolator in the following patch. - Avinash ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57628/#review169187 ----------------------------------------------------------- On March 17, 2017, 5:12 a.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57628/ > ----------------------------------------------------------- > > (Updated March 17, 2017, 5:12 a.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6022 > https://issues.apache.org/jira/browse/MESOS-6022 > > > Repository: mesos > > > Description > ------- > > Added a utility function to get back non-loopback address on the host. > > > Diffs > ----- > > src/tests/utils.hpp cdbbc1c611bbcf2d6548f6b65fb08c6a4831b7a8 > src/tests/utils.cpp bc5c8abd6d0a70a092e1a54ea402463c599c15a7 > > > Diff: https://reviews.apache.org/r/57628/diff/2/ > > > Testing > ------- > > sudo ./bin/mesos-tests.sh --gtest_filter=CniIsolator*.* > > > Thanks, > > Avinash sridharan > >
