----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56217/#review169272 -----------------------------------------------------------
Fix it, then Ship it! src/launcher/default_executor.cpp Lines 962 (patched) <https://reviews.apache.org/r/56217/#comment241621> as discussed in previous review, this is not safe. src/launcher/default_executor.cpp Lines 1069 (patched) <https://reviews.apache.org/r/56217/#comment241622> LOG(FATAL) - Vinod Kone On March 16, 2017, 4:45 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56217/ > ----------------------------------------------------------- > > (Updated March 16, 2017, 4:45 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-7249 > https://issues.apache.org/jira/browse/MESOS-7249 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/launcher/default_executor.cpp cbd4f7ecd042e7fa603bd69774d95472df2c896d > > > Diff: https://reviews.apache.org/r/56217/diff/4/ > > > Testing > ------- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > >
