----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57534/#review169323 -----------------------------------------------------------
src/authorizer/local/authorizer.cpp Lines 1155 (patched) <https://reviews.apache.org/r/57534/#comment241668> s/acls.register_agents/acls.register_agents.agent/ src/tests/authorization_tests.cpp Lines 4267-4268 (patched) <https://reviews.apache.org/r/57534/#comment241681> Newline src/tests/authorization_tests.cpp Lines 4270 (patched) <https://reviews.apache.org/r/57534/#comment241682> Could you also add a test case with the ANY subject? - Greg Mann On March 15, 2017, 12:40 a.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57534/ > ----------------------------------------------------------- > > (Updated March 15, 2017, 12:40 a.m.) > > > Review request for mesos, Adam B, Anindya Sinha, Alexander Rojas, and Greg > Mann. > > > Bugs: MESOS-7097 > https://issues.apache.org/jira/browse/MESOS-7097 > > > Repository: mesos > > > Description > ------- > > Added and implemented RegisterAgent ACL. > > > Diffs > ----- > > include/mesos/authorizer/acls.proto > e75e1879435f1c2bce47a86e9feebf9d051e969b > include/mesos/authorizer/authorizer.proto > 736f76d552956f2351ffd40fc51d088dff83f8c8 > src/authorizer/local/authorizer.cpp > be8037299601427e5d5e79f58f77eea3f89579d0 > src/tests/authorization_tests.cpp cd15add7d7b01c2b316ac946e017a4d0b502237f > > > Diff: https://reviews.apache.org/r/57534/diff/3/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
