----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57696/#review169464 -----------------------------------------------------------
Fix it, then Ship it! src/common/type_utils.cpp Lines 478 (patched) <https://reviews.apache.org/r/57696/#comment241816> I'd remove the commas after the check types. - Gastón Kleiman On March 20, 2017, 11:56 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57696/ > ----------------------------------------------------------- > > (Updated March 20, 2017, 11:56 a.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > include/mesos/type_utils.hpp 62187432093b7a5172a831a8782a8097d42a441a > include/mesos/v1/mesos.hpp f5e08790c8abf3df4ed780a929335abd1dc97db6 > src/common/type_utils.cpp 1fce5221906d4e17eaee181c4486b6bde148d8e7 > src/launcher/default_executor.cpp cbd4f7ecd042e7fa603bd69774d95472df2c896d > src/launcher/executor.cpp bd3c0cf6ae2329ed308888d6ab4b2ab3e7a90a46 > src/v1/mesos.cpp 3d9281dcbf806fd5440b4a10bed5f99fc89f08ce > > > Diff: https://reviews.apache.org/r/57696/diff/3/ > > > Testing > ------- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > >
