----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57788/#review169477 -----------------------------------------------------------
Ship it! Hm.. seems like there was no test for this "optimization" if the tests pass, did you do a scan of the allocator unit tests to be sure we're not leaving a stale test lying around? - Benjamin Mahler On March 20, 2017, 6:14 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57788/ > ----------------------------------------------------------- > > (Updated March 20, 2017, 6:14 p.m.) > > > Review request for mesos, Adam B, Benjamin Bannier, Benjamin Mahler, and > Michael Park. > > > Repository: mesos > > > Description > ------- > > When the weight is changed for one or more roles, the allocator will no > longer do a batch allocation. The weight change will be reflected in the > next allocation, which should be sufficient. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 8d54a8cca1bb478f4437f68c5e14f66a9f9bb9e9 > > > Diff: https://reviews.apache.org/r/57788/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
