> On March 20, 2017, 8:52 p.m., Joseph Wu wrote: > > src/tests/check_tests.cpp > > Lines 747-750 (patched) > > <https://reviews.apache.org/r/57775/diff/2/?file=1668402#file1668402line747> > > > > I don't recognize this test (so I assume it's been added in this > > chain)... > > > > Can you assign the TODO to yourself? Or to me (`josephw`). > > Alexander Rukletsov wrote: > It is indeed a new test. Here is where this TODO is coming from. I can > assign both to you : ).
Here is where this TODO is coming from: https://github.com/apache/mesos/blob/05e9a1d40572b8383a582e15663d861b134a7dad/src/tests/health_check_tests.cpp#L1330-L1333 - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57775/#review169499 ----------------------------------------------------------- On March 20, 2017, 5:02 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57775/ > ----------------------------------------------------------- > > (Updated March 20, 2017, 5:02 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Gastón Kleiman, and Vinod > Kone. > > > Bugs: MESOS-6906 > https://issues.apache.org/jira/browse/MESOS-6906 > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/checks/checker.cpp 314354cc374b453ec12e25e3d4730a92697468cf > src/tests/check_tests.cpp f035c16920deaf559420ae0d7d881330ff65ae44 > > > Diff: https://reviews.apache.org/r/57775/diff/2/ > > > Testing > ------- > > make check on Linux and Windows > > > Thanks, > > Alexander Rukletsov > >
