-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57774/#review169585
-----------------------------------------------------------
I think that we should fail the task if they include a check. We do the
following for COMMAND (health)checks in the DefaultExecutor:
```
// TODO(anand): Add support for command health checks.
CHECK_NE(HealthCheck::COMMAND, task.health_check().type())
<< "Command health checks are not supported yet";
```
IIRC this results in `TASK_ERROR`.
- Gastón Kleiman
On March 20, 2017, 2:29 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57774/
> -----------------------------------------------------------
>
> (Updated March 20, 2017, 2:29 p.m.)
>
>
> Review request for mesos, Gastón Kleiman and Vinod Kone.
>
>
> Bugs: MESOS-7250
> https://issues.apache.org/jira/browse/MESOS-7250
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/docker/executor.cpp b652a99340f6bbbef2dbdd3a6e10333f32762c0f
> src/tests/check_tests.cpp f035c16920deaf559420ae0d7d881330ff65ae44
>
>
> Diff: https://reviews.apache.org/r/57774/diff/2/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
