----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57666/#review169588 -----------------------------------------------------------
Looks good. As per our offline discussion, do you want to add the `http_executor_authenticator` flag to this review or do you intend to do that in a separate review? Either is fine with me. docs/configuration.md Lines 1056 (patched) <https://reviews.apache.org/r/57666/#comment242017> Can we also add a comment that this flag only works with SSL builds? - Anand Mazumdar On March 21, 2017, 4:21 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57666/ > ----------------------------------------------------------- > > (Updated March 21, 2017, 4:21 p.m.) > > > Review request for mesos, Anand Mazumdar, Alexander Rojas, and Vinod Kone. > > > Bugs: MESOS-6998 > https://issues.apache.org/jira/browse/MESOS-6998 > > > Repository: mesos > > > Description > ------- > > This patch adds a new agent flag, `--authenticate_http_executors`, > which requires authentication on the V1 executor API and loads the > default JWT authenticator. > > > Diffs > ----- > > docs/configuration.md 9f747406e91840335f97c0166ca75373e47d319b > src/slave/flags.hpp 2c4bd6ae628a272a4c6c2f02670baef011df4505 > src/slave/flags.cpp 4637ca62b257921c1e1f7019864d968f07fca8a1 > > > Diff: https://reviews.apache.org/r/57666/diff/5/ > > > Testing > ------- > > make check > > > Thanks, > > Greg Mann > >
