-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57857/
-----------------------------------------------------------
(Updated March 22, 2017, 7:09 p.m.)
Review request for mesos, John Kordich and Joseph Wu.
Changes
-------
Fix script to be able to update posted review.
Bugs: MESOS-7287
https://issues.apache.org/jira/browse/MESOS-7287
Repository: mesos
Description (updated)
-------
Windows cannot find `rbt` because the command name is `rbt.cmd`;
the extension is required.
Because Windows (PowerShell and cmd) does not support shebangs,
the usage of this script on Windows is:
python support\post-reviews.py
Windows does not have the `cat` command, so replace its usage
with `git rev-parse --verify <branch>`.
Using `os.path.join` for URLs on Windows does not work,
as the Windows path separator is `` instead of `/`.
This broke updating previously submitted reviews.
We fix it by using `urlparse.urljoin` for the joining the
base URL with rest of the URL.
Note that colors do not always work on Windows, but can work,
so we leave them enabled.
Diffs (updated)
-----
support/post-reviews.py e4620e893a77dc2442b63b6d9c49626d82860d8d
Diff: https://reviews.apache.org/r/57857/diff/2/
Changes: https://reviews.apache.org/r/57857/diff/1-2/
Testing
-------
Posted this patch.
Thanks,
Andrew Schwartzmeyer
