----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57860/#review169823 -----------------------------------------------------------
src/docker/docker.cpp Lines 825 (patched) <https://reviews.apache.org/r/57860/#comment242474> What if `environmentVariables` has env vars with the same names that vars from `os::environment()`? Looks like the task's env will be changed! - Alexander Rukletsov On March 22, 2017, 8:33 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57860/ > ----------------------------------------------------------- > > (Updated March 22, 2017, 8:33 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Gilbert Song, James > DeFelice, Jie Yu, and Joseph Wu. > > > Bugs: MESOS-6951 > https://issues.apache.org/jira/browse/MESOS-6951 > > > Repository: mesos > > > Description > ------- > > Manually backported for 1.2.x. > > > Diffs > ----- > > src/docker/docker.cpp 68042fd6f3b19c12cddd0d2e74ae064ceceb6a8c > > > Diff: https://reviews.apache.org/r/57860/diff/1/ > > > Testing > ------- > > make check & sudo ./bin/mesos-tests.sh > > Functional testing - running ps while docker test active to confirm we do not > leak values to the commandline; > > ``` > /usr/bin/docker-current -H unix:///var/run/docker.sock run --cpu-shares 2048 > --memory 1073741824 -e MESOS_CONTAINER_NAME -e MESOS_SANDBOX -v > /tmp/DockerContainerizerTest_ROOT_DOCKER_TaskKillingCapability_15mNp9/slaves/0892768e-2de9-4ce1-bfcf-206f1e74926a-S0/frameworks/0892768e-2de9-4ce1-bfcf-206f1e74926a-0000/executors/1/runs/1e815a9f-87d1-4f43-a197-3e7e34d03d1b:/mnt/mes > ``` > > > Thanks, > > Till Toenshoff > >
