----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57840/#review169841 -----------------------------------------------------------
Ship it! LGTM src/authentication/executor/jwt_secret_generator.hpp Line 29 (original), 28 (patched) <https://reviews.apache.org/r/57840/#comment242517> We should do a sweep to make the namespaces of files consistent in the `src/authentication/*` folder later. e.g., the `cram_md5` authenticator uses `mesos::internal::cram_md5`. - Anand Mazumdar On March 22, 2017, 2:37 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57840/ > ----------------------------------------------------------- > > (Updated March 22, 2017, 2:37 p.m.) > > > Review request for mesos and Anand Mazumdar. > > > Bugs: MESOS-6999 > https://issues.apache.org/jira/browse/MESOS-6999 > > > Repository: mesos > > > Description > ------- > > This patch updates the namespaces of the secret generators. > The `SecretGenerator` is placed into `mesos::`, consistent > with other classes declared in files in the same directory. > The implementations in `src/authentication/` do not exhibit > a consistent pattern, so the `JWTSecretGenerator` was placed > in a namespace indicative of its directory structure: > `mesos::authentication::executor`. > > > Diffs > ----- > > include/mesos/authentication/secret_generator.hpp > f2fb0e7f41f2267f9764f0dab5b1e98ce83d2529 > include/mesos/module/secret_generator.hpp > c8b7d8cb818b3a38a05d359b6755359f073c767d > src/authentication/executor/jwt_secret_generator.hpp > a945358d1808c339355264e623862222a4d4243a > src/authentication/executor/jwt_secret_generator.cpp > 6aed6bdd753996e27bc27001104d27fc785d56d8 > src/tests/secret_generator_tests.cpp > 81fd54dfa0a508c20b6d11ff62d9a207066be8f4 > > > Diff: https://reviews.apache.org/r/57840/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >
