> On March 24, 2017, 2:29 a.m., Adam B wrote: > > src/launcher/executor.cpp > > Lines 494 (patched) > > <https://reviews.apache.org/r/57762/diff/7/?file=1673749#file1673749line494> > > > > "Overwriting environment variable 'foo' with value from task > > environment."
This is not necessarily true. Duplicates might be in task environment as well. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57762/#review169955 ----------------------------------------------------------- On March 24, 2017, 2:24 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57762/ > ----------------------------------------------------------- > > (Updated March 24, 2017, 2:24 a.m.) > > > Review request for mesos, Adam B, Benjamin Bannier, Greg Mann, Jie Yu, and > Joseph Wu. > > > Bugs: MESOS-7263 > https://issues.apache.org/jira/browse/MESOS-7263 > > > Repository: mesos > > > Description > ------- > > see summary. > > > Diffs > ----- > > src/launcher/executor.cpp db703f054decbca62f7fbe98f5d28f6e4c6c9b0f > > > Diff: https://reviews.apache.org/r/57762/diff/7/ > > > Testing > ------- > > make check + functional testing.. > > > Thanks, > > Till Toenshoff > >
