----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57896/#review169960 -----------------------------------------------------------
Patch looks great! Reviews applied: [57896] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On March 23, 2017, 11:05 p.m., Armand Grillet wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57896/ > ----------------------------------------------------------- > > (Updated March 23, 2017, 11:05 p.m.) > > > Review request for mesos and Kevin Klues. > > > Bugs: MESOS-7269 > https://issues.apache.org/jira/browse/MESOS-7269 > > > Repository: mesos > > > Description > ------- > > Documentation added to create a correct configuration file. > Plugin to handle this configuration file added. > config.py moved to settings.py to differentiate it from the plugin. > > > Diffs > ----- > > src/cli_new/README.md 0e60515b71192ce1a544711948a5c17a6f9002af > src/cli_new/bin/config.py 274f8c63b0c642637f17aa2e3c8c4a8a5a059e37 > src/cli_new/bin/main.py bbfb52c894540158c70e0f50ebb8a277b692d54d > src/cli_new/bin/settings.py PRE-CREATION > src/cli_new/lib/mesos/plugins/config/__init__.py PRE-CREATION > src/cli_new/lib/mesos/plugins/config/main.py PRE-CREATION > src/cli_new/pip-requirements.txt 9cc8d096ac353f4ed2d40000318f2d0e439a6edf > > > Diff: https://reviews.apache.org/r/57896/diff/1/ > > > Testing > ------- > > Tested manually, PEP8 and Pylint used to make sure that the code style is > correct. > > > Thanks, > > Armand Grillet > >
